Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MULTI-321: Refactor logic to be cleaner and remove unnecessary config data #43

Merged
merged 2 commits into from
Nov 26, 2024
Merged

MULTI-321: Refactor logic to be cleaner and remove unnecessary config data #43

merged 2 commits into from
Nov 26, 2024

Conversation

EricGhildyal
Copy link
Contributor

No description provided.

@EricGhildyal EricGhildyal self-assigned this Nov 26, 2024
RobbieMcKinstry
RobbieMcKinstry approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@RobbieMcKinstry RobbieMcKinstry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/adapters/ingresses/apig.rs Outdated Show resolved Hide resolved
@EricGhildyal EricGhildyal added this pull request to the merge queue Nov 26, 2024
Merged via the queue into trunk with commit 4e22278 Nov 26, 2024
9 checks passed
@EricGhildyal EricGhildyal deleted the eric/multi-321 branch November 26, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieMcKinstry RobbieMcKinstry RobbieMcKinstry approved these changes

Assignees

@EricGhildyal EricGhildyal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricGhildyal @RobbieMcKinstry